uefi: Add bindings for the HII_CONFIG_ROUTING protocol #1753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seijikun
changed the title
seijikun
force-pushed
the
mr-hii-configrouting
branch
4 times, most recently
from
6380ed3 to
2e556f1
Compare
phip1611
reviewed
Sep 5, 2025
seijikun
force-pushed
the
mr-hii-configrouting
branch
from
2e556f1 to
0c54e18
Compare
phip1611
approved these changes
Sep 13, 2025
| let size_bytes = data.len() / 2 + 2; // includes \0 terminator | ||
| let size_chars = size_bytes / 2; | ||
| let mut bfr = AlignedBuffer::from_size_align(size_bytes, 2).ok()?; | ||
| bfr.copy_from_iter(Self::parse_bytes_from_hex(data).chain([0, 0])); |
There was a problem hiding this comment.
is the [0, 0] some form of termiation?
There was a problem hiding this comment.
Yes, the [0, 0] bytes is a uint16 0.
I added the null terminator so that I could use the CStr16::from_u16_* APIs.
I must admit, I'm somewhat at odds with the entire UTF-16 string API surface of uefi.
| }; | ||
| let value = match splitter.next() { | ||
| Some(("VALUE", Some(data))) => Self::parse_bytes_from_hex(data).collect(), | ||
| Some(("VALUE", Some(data))) => Self::parse_bytes_from_hex(data).rev().collect(), |
There was a problem hiding this comment.
nit: why is it necessary to rev the bytes here??
There was a problem hiding this comment.
I added a comment:
// The uefi specification declares `VALUE` as being a "number" of arbitrary length.
// And numbers have to be endianess-corrected. Thus, the bytes represented by a value's
// hex string of arbitrary length have to be reversed to account for that weird encoding.The short form is: "absolutely no idea. I checked it, and it's true" 😆
I've seen it stated somewhere else and was surprised that they were right.
https://github.com/Kostr/UEFI-Lessons/tree/master/Lessons_uncategorized/Lesson_Configuration_Language_5
^ This repo is worth more than gold!
seijikun
force-pushed
the
mr-hii-configrouting
branch
from
0c54e18 to
2977208
Compare
seijikun
force-pushed
the
mr-hii-configrouting
branch
from
2977208 to
ef2b00d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still had this lying around as experiment.
Polished it up a bit for the merge request.
It's best to review this commit-by-commit.
Checklist